fix(isPassportNumber): fix regex Azerbaijan by amaliacatalina · Pull Request #2284 · validatorjs/validator.js

Skip to content

Navigation Menu

Sign in

Appearance settings

Conversation

@amaliacatalina

fix(isPassportNumber): regex fix for Azerbaijan

Fixed regex for Azerbaijan isPassportNumber

https://irb.gc.ca/en/country-information/rir/Pages/index.aspx?doc=455354&pls=1
"According to Keesing, the passport number is 8 digits preceded by a letter (ibid.)"

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)
Update isPassportNumber.js

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (b958bd7) to head (f66253a).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2284   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2454     2454           
  Branches      619      619           
=======================================
  Hits         2453     2453           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stickyrst

Awesome, thanks! Needed this

WikiRik

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Please update the PR title to fix(isPassportNumber): fix regex Azerbaijan

Also, this fixes #2274

@amaliacatalina amaliacatalina changed the title Regex fix for Azerbaijan fix(isPassportNumber): fix regex Azerbaijan

Sep 14, 2023

@amaliacatalina

Code changes look good. Please update the PR title to fix(isPassportNumber): fix regex Azerbaijan

Also, this fixes #2274

Name changed.

@stickyrst

Hello,

@WikiRik what do we need to do to approve this one?

ssm0801

@stickyrst

Hello! This has still not been approved

@stickyrst

how is this still not merged yet?

rubiin

profnandaa

This was referenced

Sep 10, 2024

@vky5 vky5 mentioned this pull request

Sep 15, 2024

This was referenced

Sep 19, 2024

This was referenced

Sep 22, 2024

Labels