feat(ulid): ULID validation by arafatkn · Pull Request #2294 · validatorjs/validator.js

@arafatkn

Added validation for ULID (Universally Unique Lexicographically Sortable Identifier).

Read more details on ULID in github:ulid/spec
ULID Generator and validations on https://ulid.page

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@arafatkn

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (f81d857) to head (9891a3b).
Report is 1 commits behind head on master.

Current head 9891a3b differs from pull request most recent head 0995b5c

Please upload reports for the commit 0995b5c to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2294      +/-   ##
===========================================
- Coverage   100.00%   99.95%   -0.05%     
===========================================
  Files          110      108       -2     
  Lines         2510     2455      -55     
  Branches       633      620      -13     
===========================================
- Hits          2510     2454      -56     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rubiin

rubiin previously approved these changes May 10, 2024

profnandaa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pls fix the merge conflict and we should be good to go.

@arafatkn

@arafatkn

rubiin

rubiin previously approved these changes Jun 22, 2024

@rubiin

rubiin

@rubiin rubiin removed the mc-to-land

Just merge-conflict standing between the PR and landing.

label

Jun 23, 2024

profnandaa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM