feat(isISO4217): update iso4217 currency codes according to wiki by cbodtorf · Pull Request #2332 · validatorjs/validator.js
Conversation
Copy link Copy Markdown
Contributor
cbodtorf
commented
Oct 27, 2023
cbodtorf
commented
feat(isISO4217): update iso4217 currency codes according to wiki
- Removed 'CUC' and 'HRK' currency codes
| Code | Num | D | Currency | From | Until | Replaced by |
|---|---|---|---|---|---|---|
| HRK | 191 | 2 | Croatian kuna | 1994-05-30 | 2023-01-01 | EUR[31] |
| CUC | 931 | 2 | Cuban convertible peso | 2022 | CUP |
- Added 'SLE' and 'VED' currency codes
| Code | Num | D | Currency | Locations |
|---|---|---|---|---|
| SLE | 925 | 2 | Sierra Leonean leone (new leone)[12][13][14] | Sierra Leone |
| VED | 926 | 2 | Venezuelan digital bolívar[18] | Venezuela |
Resources:
Checklist
- PR contains only changes related; no stray files, etc.
- README updated (where applicable)
- Tests written (where applicable)
- References provided in PR (where applicable)
cbodtorf added 2 commits
October 27, 2023 11:35Copy link Copy Markdown
Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (
b958bd7) 99.95% compared to head (5c382bc) 99.95%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #2332 +/- ## ========================================== - Coverage 99.95% 99.95% -0.01% ========================================== Files 107 107 Lines 2454 2449 -5 Branches 619 619 ========================================== - Hits 2453 2448 -5 Partials 1 1
| Files | Coverage Δ | |
|---|---|---|
| src/lib/isISO4217.js | 100.00% <ø> (ø) |
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
WikiRik previously approved these changes Oct 29, 2023
rubiin previously approved these changes May 12, 2024
rubiin
dismissed stale reviews from WikiRik and themself
via
030033d
rubiin
requested review from
WikiRik and
profnandaa
rubiin approved these changes Jun 3, 2024
profnandaa approved these changes Jun 4, 2024
profnandaa
merged commit
f2bc5ed
into
validatorjs:master
Copy link Copy Markdown
Member
profnandaa
commented
Jun 4, 2024
profnandaa commented
Jun 4, 2024Thanks for your contrib!
WikiRik
mentioned this pull request
fossabot
bot
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

