feat(isISO4217): update iso4217 currency codes according to wiki by cbodtorf · Pull Request #2332 · validatorjs/validator.js

Conversation

@cbodtorf

Copy link Copy Markdown

Contributor

feat(isISO4217): update iso4217 currency codes according to wiki

  • Removed 'CUC' and 'HRK' currency codes
Code Num D Currency From Until Replaced by
HRK 191 2 Croatian kuna 1994-05-30 2023-01-01 EUR[31]
CUC 931 2 Cuban convertible peso 2022 CUP
  • Added 'SLE' and 'VED' currency codes
Code Num D Currency Locations
SLE 925 2 Sierra Leonean leone (new leone)[12][13][14] image Sierra Leone
VED 926 2 Venezuelan digital bolívar[18] image Venezuela

Resources:

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov

Copy link Copy Markdown

codecov bot commented

Oct 27, 2023

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (5c382bc) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2332      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              
Files Coverage Δ
src/lib/isISO4217.js 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WikiRik

WikiRik previously approved these changes Oct 29, 2023

rubiin

rubiin previously approved these changes May 12, 2024

@rubiin rubiin dismissed stale reviews from WikiRik and themself via 030033d

June 3, 2024 14:34

@rubiin rubiin requested review from WikiRik and profnandaa

June 3, 2024 14:34

@profnandaa profnandaa merged commit f2bc5ed into validatorjs:master

Jun 4, 2024

@profnandaa

Copy link Copy Markdown

Member

Thanks for your contrib!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@profnandaa profnandaa profnandaa approved these changes

@rubiin rubiin rubiin approved these changes

@WikiRik WikiRik Awaiting requested review from WikiRik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbodtorf @profnandaa @rubiin @WikiRik