feat(isVAT): improved ABN (AU GST/VAT ID) validation by matthewberryman · Pull Request #2343 · validatorjs/validator.js
Conversation
Implemented correct ABN (AU GST/VAT ID) validation per the official reference (see also this reference and implementation)
Checklist
- PR contains only changes related; no stray files, etc.
- README updated: N/A
- Tests written (where applicable)
- References provided in PR (where applicable)
Codecov Report
All modified and coverable lines are covered by tests ✅
Comparison is base (
b958bd7) 99.95% compared to head (730fbcc) 99.95%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #2343 +/- ## ======================================= Coverage 99.95% 99.95% ======================================= Files 107 107 Lines 2454 2459 +5 Branches 619 621 +2 ======================================= + Hits 2453 2458 +5 Partials 1 1
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
matthewberryman
changed the title
improved ABN (AU VAT) validation
feat(isVAT): improved ABN (AU GST/VAT ID) validation
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contrib!
vky5
mentioned this pull request
vky5
mentioned this pull request
This was referenced
Sep 20, 2024This was referenced
Sep 22, 2024This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters