feat(isUUID): support uuid v7 by ruscon · Pull Request #2345 · validatorjs/validator.js

Conversation

@ruscon

closes #2344

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (b261c36) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2345      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WikiRik

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruscon

WikiRik

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

somarjun

rubiin

rubiin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

devlopersabbir

@Chrisp1tv

Hello @ruscon @WikiRik, is there something preventing this PR from being merged? 🙂

profnandaa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

And sorry for the delayed response. Will go into the next release.

@vky5 vky5 mentioned this pull request

Sep 15, 2024

This was referenced

Sep 20, 2024

This was referenced

Sep 22, 2024

Reviewers

@profnandaa profnandaa profnandaa approved these changes

@rubiin rubiin rubiin approved these changes

@WikiRik WikiRik WikiRik approved these changes

@tux-tn tux-tn Awaiting requested review from tux-tn

+2 more reviewers

@somarjun somarjun somarjun approved these changes

Reviewers whose approvals may not affect merge requirements

Labels