Home Original page

feat(isRgbColor) Allow second digit in rgba alpha value by controlol · Pull Request #2346 · validatorjs/validator.js

Conversation

@controlol

Updated the RegExp to allow a secondary digit for the alpha value when checking a rgba color. Added required tests and test the number of digits for the rgbaColorPercent RegExp.

References
Modern browsers support multiple decimals for the alpha value in rgba() color values. This is also allowed in the CSS standard: https://www.w3.org/TR/css-color-3/#transparency

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (42ddf04) 99.95%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2346      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rubiin

rubiin previously approved these changes Dec 27, 2023

@WikiRik

I'm having a bit of trouble figuring out how many digits are allowed in the alpha value. Do you have any resources for that?

@controlol

This post suggests that the color is 32 bit and therefor 8 bits available for transparency (256 possibilities). So 1/256 has a precision of approximately 0.004 or 0.4%.

Unfortunately, the W3C page linked in the original pr does not state how many digits can be used. Many browsers also support rgba values in hexadecimal notation, although this is not part of the CSS3 standard.

devlopersabbir

WikiRik

WikiRik previously approved these changes Mar 15, 2024

@controlol

I just checked the PR by marcopixel. If this validation was intented for use with CSS I would change the current commit to use 0?\.\d+ instead of 0?\.\d{1,2}.
Also checks should be added without a number after the dot.

WikiRik

rubiin

@WikiRik

@rubiin it seems we have merged this with a failing test. I'll fix this later today or tomorrow

@WikiRik

Labels