Home Original page

feat(isPostalCode): add validation for Colombian postal code by jorgevrgs · Pull Request #2415 · validatorjs/validator.js

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jorgevrgs

Copy link Copy Markdown

Contributor

@jorgevrgs jorgevrgs commented

Jun 5, 2024

•

edited

Loading

feat(isPostalCode): add validation for Colombian postal code

  • Updated isPostalCode by adding CO country code
  • Add valid and invalid tests

References:

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@jorgevrgs jorgevrgs marked this pull request as ready for review

June 5, 2024 20:43
Copy link Copy Markdown

Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update readme

jorgevrgs reacted with thumbs up emoji 
feat(isPostalCode): add more accurated regexp including state limits

fix(isPostalCode): update state codes

fix(isPostalCode): add missing trailling comma

docs(isPostalCode): add CO to the locale list

@rubiin rubiin requested a review from profnandaa

June 6, 2024 16:37

@rubiin rubiin added the ✅ LGTM label

Jun 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@profnandaa profnandaa profnandaa approved these changes

@rubiin rubiin rubiin approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jorgevrgs @profnandaa @rubiin