fix(isInt, isFloat): Handle undefined and null values by Daniyal-Qureshi · Pull Request #2416 · validatorjs/validator.js
Navigation Menu
{{ message }}
validatorjs / validator.js Public
- Notifications You must be signed in to change notification settings
- Fork 2.4k
Merged
profnandaa merged 1 commit intovalidatorjs:masterfrom
Jun 22, 2024Merged
Conversation
Copy link Copy Markdown
Contributor
Daniyal-Qureshi
commented
Jun 6, 2024
Daniyal-Qureshi
commented
Enhanced both the 'isInt' and 'isFloat' functions by incorporating checks for null and undefined values, enabling them to handle cases where the input may be null or undefined
Issue Referenced
Checklist
- PR contains only changes related; no stray files, etc.
- README updated (where applicable)
- Tests written (where applicable)
- References provided in PR (where applicable)
rubiin approved these changes Jun 7, 2024
rubiin
requested a review
from profnandaa
Copy link Copy Markdown
Contributor Author
Daniyal-Qureshi
commented
Jun 11, 2024
Daniyal-Qureshi commented
Jun 11, 2024Hi @profnandaa,
could you please review this PR.
profnandaa approved these changes Jun 22, 2024
Copy link Copy Markdown
Member
profnandaa
left a comment
profnandaa
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix! 🎉
profnandaa
merged commit
acdebd6
into
validatorjs:master
Copy link Copy Markdown
CptMaumau
commented
Aug 30, 2024
CptMaumau commented
Aug 30, 2024Hi @profnandaa will it be part of a release soon?
pano9000
mentioned this pull request
WikiRik
mentioned this pull request
fossabot
bot
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment