feat(isURL): add max_allowed_length option by pinkiesky · Pull Request #2439 · validatorjs/validator.js
Navigation Menu
{{ message }}
validatorjs / validator.js Public
- Notifications You must be signed in to change notification settings
- Fork 2.4k
Merged
profnandaa merged 1 commit intovalidatorjs:masterfrom
Aug 15, 2024Merged
feat(isURL): add max_allowed_length option#2439
profnandaa merged 1 commit intovalidatorjs:masterfrom
feat(isURL): add max_allowed_length option#2439
profnandaa merged 1 commit intovalidatorjs:masterfrom
Conversation
Copy link Copy Markdown
Contributor
pinkiesky
commented
Aug 13, 2024
pinkiesky
commented
This PR enhances the isURL validator by introducing an option to customize the maximum allowed URL length, replacing the previously hardcoded limit.
Checklist
- PR contains only changes related; no stray files, etc.
- README updated (where applicable)
- Tests written (where applicable)
- References provided in PR (where applicable)
rubiin
requested a review
from profnandaa
rubiin approved these changes Aug 14, 2024
profnandaa approved these changes Aug 15, 2024
Copy link Copy Markdown
Member
profnandaa
left a comment
profnandaa
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contrib! 🎉
profnandaa
merged commit
542cfba
into
validatorjs:master
a9261020
mentioned this pull request
WikiRik
mentioned this pull request
fossabot
bot
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants