Home Original page

fix(isPostalCode): Update French postal code regex by Rajput-Balram · Pull Request #2479 · validatorjs/validator.js

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Rajput-Balram

Copy link Copy Markdown

Contributor

This PR updates the regex pattern used for validating French postal codes in the isPostalCode function.

  • Replaces outdated regex (/^\d{2}\s?\d{3}$/) with accurate pattern (/^(?:(?:0[1-9]|[1-8]\d|9[0-5])\d{3}|97[1-46]\d{2})$/)
  • Updates the test fixtures in validators.test.js to ensure accurate testing of French postal code validation.

Fixes #2478

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)
kinooyume and leup reacted with thumbs up emoji

@Rajput-Balram

Copy link Copy Markdown

Contributor Author

Requesting Review @WikiRik

@rubiin rubiin requested a review from WikiRik

November 12, 2024 16:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubiin rubiin rubiin approved these changes

@WikiRik WikiRik WikiRik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong regex for french postal code in isPostalCode

3 participants

@Rajput-Balram @rubiin @WikiRik