feat(isEmail): allow regexp in host_whitelist and host_blacklist by weikangchia · Pull Request #2494 · validatorjs/validator.js

@weikangchia

This PR enhance the host_whitelist and host_blacklist of isEmail validator to use regexp.

References: #562

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@weikangchia

@rubiin

rubiin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (f81d857) to head (541152c).
Report is 16 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2494      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%     
===========================================
  Files          110      112       +2     
  Lines         2510     2526      +16     
  Branches       633      638       +5     
===========================================
+ Hits          2510     2525      +15     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@weikangchia

WikiRik

@WikiRik WikiRik changed the title feat(isEmail): enhance isEmail host_whitelist and host_blacklist to use regexp feat(isEmail): allow regexp in host_whitelist and host_blacklist

Nov 21, 2024

@weikangchia

Thanks @rubiin and @WikiRik for the review. Just curious when is the next release and will this change be part of the next release as I would like to use this feature in my project.