feat(isPhoneNumber): add validation for Macedonian [mk-MK] phone number by eshward95 · Pull Request #2500 · validatorjs/validator.js

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@eshward95

Copy link Copy Markdown

Contributor

@eshward95 eshward95 commented

Nov 21, 2024

edited

Loading

Description

  • Created a regular expression to validate Macedonian phone numbers.
  • The regex supports both international and local formats, ensuring compatibility with various phone number representations.
  • Added test cases to verify the correctness of the new regex pattern.

References:

Issue

#2497

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)
antonio-ivanovski reacted with thumbs up emoji

rubiin

rubiin previously approved these changes Nov 21, 2024

@rubiin rubiin requested a review from WikiRik

November 21, 2024 13:33

@eshward95

Copy link Copy Markdown

Contributor Author

Can we merge this PR @rubiin @pano9000 @WikiRik ?

@WikiRik WikiRik changed the title feat: Validation for macedonian [mk-MK] phone number added feat(isPhoneNumber): add validation for Macedonian [mk-MK] phone number

Jan 30, 2025

@WikiRik WikiRik merged commit a7d5cff into validatorjs:master

Jan 30, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubiin rubiin rubiin approved these changes

@WikiRik WikiRik WikiRik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eshward95 @rubiin @WikiRik