feat(isTime): add `withOptionalSeconds` option by greenbea · Pull Request #2521 · validatorjs/validator.js

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@greenbea

Copy link Copy Markdown

Contributor

@greenbea greenbea commented

Jan 22, 2025

edited

Loading

The withOptionalSeconds option is useful when you want to validate a time and want to allow with or without seconds.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@rubiin rubiin requested a review from WikiRik

March 16, 2025 13:26

@WikiRik WikiRik requested a review from rubiin

March 26, 2025 21:11

@WikiRik WikiRik changed the title feat(isTime) add withOptionalSeconds option feat(isTime): add withOptionalSeconds option

Mar 26, 2025

@rubiin rubiin merged commit 2866bb1 into validatorjs:master

Mar 27, 2025

@greenbea greenbea deleted the patch-1 branch

March 27, 2025 15:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubiin rubiin rubiin approved these changes

@WikiRik WikiRik WikiRik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@greenbea @rubiin @WikiRik