Fixed wrong current directory while creating a new Bookmark by ganlub · Pull Request #168 · vim-ctrlspace/vim-ctrlspace

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ganlub

Copy link

@ganlub ganlub commented

Feb 24, 2016

The first time I added a Bookmark (<a>) everything went well. But the following I added took the directory of the "visually selected one" instead of its own.

screenshot from 2016-02-25 00-03-13

@ganlub

Copy link

Author

ganlub commented

Feb 25, 2016

On :help ctrlspace section 5.5, it says to press <a> to add a new Bookmark but on the Key Reference there's <a> and <A> to "Add a new bookmark (A - with CWD)". Using <A> works good, but if I use <a>, it happens what I posted on my previous comment.

@jyscao jyscao added bug: misbehavior

minor annoyances, not workflow disruptions

enhancement: tweak & config

augment existing features, behaviors & configurations

priority: 2 - low labels

Nov 10, 2020

@jyscao

Copy link

Collaborator

jyscao commented

Nov 10, 2020

@Konfekt do you know if this PR is still relevant (it dates back to 2016...)?

@Konfekt

Copy link

Collaborator

Konfekt commented

Nov 10, 2020

Yes, It is. Indeed a proposed to add the selected bookmarked directory which is pointless.

@Konfekt

Copy link

Collaborator

Konfekt commented

Apr 13, 2022

@jyscao : This looks good to go as I see little benefit in adding the selected already added bookmark.

@ganlub : Would you mind syncing to master to resolve conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug: misbehavior

minor annoyances, not workflow disruptions

enhancement: tweak & config

augment existing features, behaviors & configurations

priority: 2 - low

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ganlub @jyscao @Konfekt