WAR-1149: Added About Us popup and information by hamdih · Pull Request #402

WAR-1149: Added About Us popup and information by hamdih · Pull Request #402 · warriorframework/warriorframework

Black Duck Security Report

Merging #402 into katana-apps-demo will decrease security risk!

Removed Components

High Risk: 1
Medium Risk: 1
Clean: 11

		"idfdir": "/home/hamdi/warriorframework/warrior/Warriorspace/Data",
		"testdata": "/home/hamdi/warriorframework/warrior/Warriorspace/Config_files",
		"pythonpath": ""
		}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hamdih,

Please remove the directory paths from the config.json.

		<ul>
		<li katana-click="katana.openProfile" url="/katana/settings/" jsurls="/static/settings/js/settings.js,">Profile Settings <i class="fa fa-user"></i></li>
		<li katana-click="katana.aboutUs">About <i class="fa fa-info"></i></li>
		<li katana-click="katana.aboutUs" url = "/katana/settings/" jsurls = "/static/settings/js/settings.js">About <i class="fa fa-info"></i></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hamdih,

There doesn't seem to be a reason why the url and jsUrls attributes were included in the new <li> tag. They can be safely removed.

		var str = "here";
		var release = str.link("https://github.com/warriorframework/warriorframework/releases");
		var meet = str.link("https://github.com/warriorframework/warriorframework/blob/master/AUTHORS#L1");
		var aboutUs = "<u> History</u><br><br>Warrior Framework started out as side project in 2015 and rapidly gained popularity within Fujitsu to become topmost provider of automation services in the company.<br><br>The potential of Warrior Framework did not go unnoticed and it was made publicly available under the Apache 2.0 License in mid 2017.<br><br>Today, Warrior Framework has successfully transformed into an Open Source Automation Platform wherein the user community can contribute back to the Platform by creating their Apps <br><br> <u> Releases </u><br><br> All the latest Warrer Release can be found " + release + "<br><br> <u> Meet the Team</u><br><br> Information about the team that build Warrior Framework can be found " + meet;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hamdih,

Rather than including html in a JS function, you can just add in in the html template you have created in index.html. Would be easier to maintain in the long run.

Hi @hamdih,

Can you please make the contents on the popup prettier?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments provided in individual files.

Hi @hamdih,

Please make the changes in this PR and then port it to the new py3 warriorframework repository. Please let me know if you have any questions about this. Thanks.

bjrr changed the title ~~Added About Us popup and information WAR-1149~~ WAR-1149: Added About Us popup and information

Aug 10, 2018