feat: network acl by vm-001 · Pull Request #253 · webhookx-io/webhookx
Navigation Menu
{{ message }}
webhookx-io / webhookx Public
- Notifications You must be signed in to change notification settings
- Fork 16
Comments
Conversation
Copy link
Collaborator
vm-001
force-pushed
the
feat/acl
branch
from
cc80120 to
d76bea0
Compare
Copy link
Codecov Report
❌ Patch coverage is 95.12195% with 6 lines in your changes missing coverage. Please review.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| worker/deliverer/http.go | 80.00% | 4 Missing and 2 partials ⚠️ |
| Flag | Coverage Δ | |
|---|---|---|
| integration | 76.54% <67.47%> (?) |
|
| unit | 13.25% <87.80%> (+1.53%) |
⬆️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| config/worker.go | 100.00% <100.00%> (ø) |
|
| db/entities/attempt.go | 100.00% <ø> (+100.00%) |
⬆️ |
| worker/deliverer/acl.go | 100.00% <100.00%> (ø) |
|
| worker/deliverer/deliverer.go | 100.00% <ø> (+100.00%) |
⬆️ |
| worker/worker.go | 74.87% <100.00%> (+74.87%) |
⬆️ |
| worker/deliverer/http.go | 83.52% <80.00%> (-3.57%) |
⬇️ |
... and 112 files with indirect coverage changes
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
vm-001
force-pushed
the
feat/acl
branch
from
d76bea0 to
70bed8c
Compare
vm-001
requested a review
from cchenggit
vm-001
force-pushed
the
feat/acl
branch
2 times, most recently
from
d03d7db to
f431fc8
Compare
vm-001
force-pushed
the
feat/acl
branch
from
f431fc8 to
a290db7
Compare
cchenggit requested changes Oct 19, 2025
worker/deliverer/http.go
Outdated
Show resolved
Hide resolved
worker/deliverer/http.go Outdated Show resolved Hide resolved
config/worker.go
Outdated
Show resolved
Hide resolved
config/worker.go Outdated Show resolved Hide resolved
vm-001 commented Oct 20, 2025
worker/worker.go
Show resolved
Hide resolved
worker/worker.go Show resolved Hide resolved
cchenggit approved these changes Oct 20, 2025
Copy link
Collaborator
cchenggit
left a comment
cchenggit
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vm-001 added 6 commits
October 20, 2025 22:37
vm-001
deleted the
feat/acl
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants