fix: change request_body and response_body columns to text by vm-001 · Pull Request #38 · webhookx-io/webhookx
Navigation Menu
{{ message }}
webhookx-io / webhookx Public
- Notifications You must be signed in to change notification settings
- Fork 16
Comments
Merged
fix: change request_body and response_body columns to text#38
webhookx-x merged 3 commits intomainfrom
fix: change request_body and response_body columns to text#38
webhookx-x merged 3 commits intomainfrom
Conversation
Copy link
Collaborator
Summary
- Fixed AtteptDetail insertion may fail when the response body is not JSON
- Changed AttemptDetailt.ResponseBody to pointer type to not store literal
nullin the database.
Copy link
Codecov Report
Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| db/dao/attempt_detail_dao.go | 75.00% | 1 Missing and 1 partial ⚠️ |
| Flag | Coverage Δ | |
|---|---|---|
| integration | 64.42% <91.30%> (+0.03%) |
⬆️ |
| unit | 12.58% <0.00%> (-0.02%) |
⬇️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| admin/api/attempts.go | 100.00% <100.00%> (ø) |
|
| db/entities/attempt.go | 100.00% <ø> (+11.76%) |
⬆️ |
| db/entities/types.go | 50.00% <100.00%> (+50.00%) |
⬆️ |
| worker/worker.go | 66.83% <100.00%> (ø) |
|
| db/dao/attempt_detail_dao.go | 88.88% <75.00%> (-11.12%) |
⬇️ |
vm-001
force-pushed
the
fix/attempt-details-schema
branch
from
4913240 to
d1bfca8
Compare
cchenggit approved these changes Oct 1, 2024
webhookx-x
changed the title
fix: change request_body and response_body to text
fix: change request_body and response_body columns to text
vm-001
force-pushed
the
fix/attempt-details-schema
branch
from
9b289e1 to
266e021
Compare
webhookx-x
self-requested a review
vm-001
force-pushed
the
fix/attempt-details-schema
branch
from
266e021 to
07f12dc
Compare
webhookx-x
merged commit
457ed17
into
main
webhookx-x
deleted the
fix/attempt-details-schema
branch
webhookx-x pushed a commit that referenced this pull request
Oct 2, 2024
vm-001
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants