feat: improve error and warning messages in overlay by snitin315 · Pull Request #4087

feat: improve error and warning messages in overlay by snitin315 · Pull Request #4087 · webpack/webpack-dev-server

This is a bugfix
This is a feature
This is a code refactor
This is a test update
This is a docs update
This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Refers #3689

improve error and warning messages in overlay.

Breaking Changes

None

Additional Info

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's add more tests

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (eea50f3) to head (3d8c2d4).
⚠️ Report is 621 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4087   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files          16       16           
  Lines        1593     1593           
  Branches      596      596           
=======================================
  Hits         1470     1470           
  Misses        114      114           
  Partials        9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Looks good, let's add more tests

yes, WIP on tests

snitin315 marked this pull request as ready for review

April 17, 2022 02:26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more tests?

Yes, can you suggest some test cases?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create errors in custom plugin with module name, message, file and etc, will be great to have even real problems from webpack, just create situation when webpack throws them