Home Original page

feat: http2 support for `connect` compatibility application by alexander-akait · Pull Request #5267 · webpack/webpack-dev-server

Conversation

@alexander-akait

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

Allow to use http2 with connect, express still doesn't support http2

Breaking Changes

No

Additional Info

No

@alexander-akait

All works fine except a deprecation warning - pillarjs/finalhandler#45, we can fix it here, I want to make a small patch and when it will be resolved we remove it

levrik

*/
const allHeaders = [];

allHeaders.push({ key: "X_TEST", value: "TEST" });

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wondered after upgrading to webpack-dev-server 5.2.1 where this header is coming from and could track it down to this PR. Looks like it's there for quite some time already and I simply didn't notice until now. Does this serve any purpose or is it maybe a left-over from some testing?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we I don't see it when merging, let's fix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 participants

@alexander-akait @levrik