Added support for SameSite cookies. by akash0x53 · Pull Request #409 · webpy/webpy
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.3k
Closed
akash0x53 wants to merge 4 commits intowebpy:masterfrom
Closed
Added support for SameSite cookies.#409
akash0x53 wants to merge 4 commits intowebpy:masterfrom
Added support for SameSite cookies.#409
akash0x53 wants to merge 4 commits intowebpy:masterfrom
Conversation
Copy link Copy Markdown
Contributor
Good to mitigate against CSRF attacks. SameSite cookies are mentioned
in draft https://tools.ietf.org/html/draft-west-first-party-cookies-07
Fix for issue #410
Copy link Copy Markdown
Contributor Author
akash0x53
commented
Feb 25, 2017
akash0x53 commented
Feb 25, 2017@anandology Please review & comment.
Copy link Copy Markdown
Member
anandology
commented
Feb 27, 2017
anandology commented
Feb 27, 2017@akash0x53 Did you notice my comment about string concatenation?
Copy link Copy Markdown
Contributor Author
Nope. I can guess comment should be about this value += '; SameSite=' + samesite. Will use placeholder
akash0x53 added 4 commits
February 28, 2017 21:51Good to mitigate against CSRF attacks. `SameSite` cookies are mentioned in draft https://tools.ietf.org/html/draft-west-first-party-cookies-07
akash0x53
force-pushed
the
cookie-fixes
branch
from
6508aca to
61053e8
Compare
akash0x53 commented Mar 3, 2017
| morsel["httponly"] = True | ||
| value = morsel.OutputString() | ||
| if samesite and samesite.lower() in ['strict', 'lax']: | ||
| samesite_attr = "; SameSite=%s" % samesite |
Copy link Copy Markdown
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go? @anandology
Copy link Copy Markdown
Contributor Author
akash0x53
commented
May 4, 2017
akash0x53 commented
May 4, 2017SameSite support PR open for Django too.
https://github.com/django/django/pull/8380/files
Copy link Copy Markdown
Contributor Author
akash0x53
commented
Jun 27, 2017
akash0x53 commented
Jun 27, 2017Any update on this PR?
Copy link Copy Markdown
Contributor
jzellman
commented
Jul 10, 2017
jzellman commented
Jul 10, 2017👍 Looks good to me, @akash0x53 maybe squash down to a single commit?
iredmail
mentioned this pull request
iredmail added a commit that referenced this pull request
Sep 16, 2019This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants