Home Original page

Fixed the issue with insert returning query by anandology · Pull Request #649 · webpy/webpy

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@anandology

Copy link Copy Markdown

Member

Closes #648

The insert ... returning ... query was not getting commited to the db
due to a recent change.

Issue webpy#648

@anandology anandology requested a review from iredmail

June 24, 2020 07:35

@anandology anandology force-pushed the 648-insert-returning branch from 1f60363 to 1fea0d9 Compare

June 24, 2020 07:37

iredmail

iredmail previously approved these changes Jun 24, 2020

Copy link Copy Markdown

Contributor

@iredmail iredmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandology

Copy link Copy Markdown

Member Author

These black issues are really frustrating.

This test was getting blocked when tried without the fix in the previous
commit.

Issue webpy#648

@anandology anandology force-pushed the 648-insert-returning branch from 22226c5 to 0067edd Compare

June 24, 2020 07:54

@anandology

Copy link Copy Markdown

Member Author

Fixed the black errors.

@iredmail iredmail merged commit b8e6eba into webpy:master

Jun 24, 2020

@anandology anandology deleted the 648-insert-returning branch

June 24, 2020 09:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iredmail iredmail iredmail approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

query("insert... returning") fails to commit

2 participants

@anandology @iredmail