Add better rotation support. Fixes bug where the plugin container would become the wrong size on rotation. by chrsmys · Pull Request #1 · willowtreeapps/Hyperion-iOS
Navigation Menu
{{ message }}
willowtreeapps / Hyperion-iOS Public
- Notifications You must be signed in to change notification settings
- Fork 90
Merged
Chris Mays (chrsmys) merged 4 commits intodevelopfrom
Dec 4, 2017Conversation
Copy link Copy Markdown
Contributor
Chris Mays (chrsmys)
commented
Dec 2, 2017
Chris Mays (chrsmys)
commented
No description provided.
Chris Mays (chrsmys)
requested a review
from Ben Humphries (iMacHumphries)
Ben Humphries (iMacHumphries) approved these changes Dec 2, 2017
Copy link Copy Markdown
Contributor
Ben Humphries (iMacHumphries)
left a comment
Ben Humphries (iMacHumphries)
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| [_pluginMenuItem setSelected:NO animated:YES]; | ||
| } | ||
|
|
||
| -(void)snapshotPluginViewWillTransitionToSize:(CGSize)size withTransitionCoordinator:(id<UIViewControllerTransitionCoordinator>)coordinator |
Copy link Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be optional, maybe?
Copy link Copy Markdown
Contributor Author
Chris Mays (chrsmys)
commented
Dec 3, 2017
Chris Mays (chrsmys) commented
Dec 3, 2017Ben Humphries (@iMacHumphries) I updated the naming there, to make it a little more obvious what is going on.
Copy link Copy Markdown
Contributor
Ben Humphries (iMacHumphries)
commented
Dec 4, 2017
Ben Humphries (iMacHumphries) commented
Dec 4, 2017LGTM
Chris Mays (chrsmys) and others added 3 commits
December 3, 2017 21:17Add circle configuation.
…ld become the wrong size on rotation.
Chris Mays (chrsmys)
force-pushed
the
bugfix/betterRotationSupport
branch
from
eea8888 to
51b4275
Compare
Chris Mays (chrsmys)
merged commit
4c56228
into
develop
Chris Mays (chrsmys)
deleted the
bugfix/betterRotationSupport
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants