Add log for nil module by iMacHumphries · Pull Request #17 · willowtreeapps/Hyperion-iOS
Navigation Menu
{{ message }}
willowtreeapps / Hyperion-iOS Public
- Notifications You must be signed in to change notification settings
- Fork 90
Merged
Ben Humphries (iMacHumphries) merged 1 commit intodevelopfrom
Dec 8, 2017Merged
Ben Humphries (iMacHumphries) merged 1 commit intodevelopfrom
Ben Humphries (iMacHumphries) merged 1 commit intodevelopfrom
Conversation
Copy link Copy Markdown
Contributor
Ben Humphries (iMacHumphries)
commented
Dec 8, 2017
Ben Humphries (iMacHumphries)
commented
No description provided.
Chris Mays (chrsmys) suggested changes Dec 8, 2017
Core/Public/HyperionManager.m
Outdated
Core/Public/HyperionManager.m Outdated
| } | ||
| else | ||
| { | ||
| NSLog(@"%@ createPluginModule returned a nil plugin module ", NSStringFromClass(pluginClass)); |
Copy link Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Can you please remove the extra space after module?
Copy link Copy Markdown
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
Ben Humphries (iMacHumphries)
force-pushed
the
bugfix/crash-on-nil-module
branch
from
4168894 to
9df54ce
Compare
Chris Mays (chrsmys) approved these changes Dec 8, 2017
Ben Humphries (iMacHumphries)
merged commit
5c8de02
into
develop
Ben Humphries (iMacHumphries)
deleted the
bugfix/crash-on-nil-module
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants