Hide Sequence implementation class by couzic · Pull Request #14 · winterbe/sequency
Thanks for your hard work. I've looked over the various changes, looks good to me.
I just have two minor notes:
- As you already mentioned in Separate operation API from implementation #11 I would also prefer to just support user-defined operations via mixins. Dropping one function would make the API a bit simpler. I would prefer the name
extendSequence(mixin)instead ofaugmentSequenceWithMixin(). - Please squash your commits into a single commit.
couzic
deleted the
hide-sequence-implementation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters