Show full command after using the `--prompt` flag by dishitpala · Pull Request #5322 · wp-cli/wp-cli

@dishitpala

#4995 Display full command after all prompts are submitted.

Screenshot 2019-11-27 at 2 10 01 AM

@dishitpala

schlessera

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should make use of WP_CLI\Utils\assoc_args_to_str() here.

Also, please add a Behat test for this.

@dishitpala

@dishitpala

@schlessera

@dishitpala Are you still up for adding a Behat test here?

@dishitpala

@schlessera

By any chance, can we merge this PR and create another issue for a test case?
As I am struggling to manage time to learn Behat.

If we can't merge PR without a test-case, then I will manage to write the test-case.

Please let me know your thought on this.

Thanks.

@schlessera

No worries, I'll look into adding a test to this myself.

@thrijith

@thrijith

@thrijith

No worries, I'll look into adding a test to this myself.

Hi @schlessera, I've taken the liberty to add tests for the change, please let me know if something needs change, Thanks!

Thanks for the PR @dishitpala!

@thrijith

schlessera

@schlessera

schlessera

@schlessera schlessera changed the title Show full command after using the --prompt flag Show full command after using the --prompt flag

Aug 26, 2020

@schlessera