Add `$wp_config_path` param for `get_wp_config_code()` by pmbaldha · Pull Request #5366 · wp-cli/wp-cli

@pmbaldha

@pmbaldha

@schlessera

@pmbaldha

@pmbaldha

@schlessera

@pmbaldha My bad, I don't think we need a test here. This is not externally accessible, and the Behat test from the other package already tests it in terms of safeguarding it against a regression.

schlessera

@pmbaldha

@pmbaldha

schlessera

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have included both old and new versions in the string... :)

@schlessera

Note: GitHub allows you to directly commit suggestions like the one I made above via the Commit suggestion button below the comment. That is generally less error-prone.

@pmbaldha @schlessera

Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>

schlessera

@schlessera schlessera changed the title Add $wp_config_path param for get_wp_config_code Add $wp_config_path param for get_wp_config_code()

Apr 8, 2020