Let `Utils\run_mysql_command()` return data by schlessera · Pull Request #5384 · wp-cli/wp-cli
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1k
Merged
schlessera merged 11 commits intomasterfrom
Apr 17, 2020Merged
Let Utils\run_mysql_command() return data#5384
schlessera merged 11 commits intomasterfrom
Let Utils\run_mysql_command() return data#5384
schlessera merged 11 commits intomasterfrom
Conversation
Copy link
Member
schlessera
commented
Apr 16, 2020
schlessera
commented
Change the Utils\run_mysql_command() so that it can also return data & errors when running a query via the mysql binary.
Fixes #5383
schlessera added 2 commits
April 16, 2020 12:29
schlessera
force-pushed
the
5383-let-run-mysql-command-return-data
branch
from
766add2 to
79d90bf
Compare
schlessera
added
breaking-change
scope:framework
labels
schlessera
added this to the
2.5.0 milestone
schlessera added 8 commits
April 16, 2020 12:56
schlessera
mentioned this pull request
schlessera
marked this pull request as ready for review
schlessera
requested a review
from a team
as a code owner
schlessera
merged commit
b702c72
into
master
schlessera
deleted the
5383-let-run-mysql-command-return-data
branch
Copy link
aidvu
commented
Jun 16, 2021
aidvu commented
Jun 16, 2021You're now storing the outputs in RAM, even if it's a wp db export and the chances of the command running out of memory are pretty high.
I think we should retain the old behavior if $send_to_shell === true. Not sure if you had any reports about this yet.
danielbachhuber
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment