Throw exception when misusing `error_to_string()` by vsamoletov · Pull Request #5405 · wp-cli/wp-cli
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1k
Merged
schlessera merged 3 commits intowp-cli:masterfrom
Jun 4, 2020Merged
Throw exception when misusing error_to_string()#5405
schlessera merged 3 commits intowp-cli:masterfrom
Throw exception when misusing error_to_string()#5405
schlessera merged 3 commits intowp-cli:masterfrom
Conversation
vsamoletov
requested a review
from a team
as a code owner
swissspidy reviewed Jun 4, 2020
tests/test-wp-cli.php
Outdated
Show resolved
Hide resolved
tests/test-wp-cli.php Outdated Show resolved Hide resolved
Copy link
Contributor Author
vsamoletov
commented
Jun 4, 2020
vsamoletov commented
Jun 4, 2020I have to add @throws to PHPDoc probably. Please let me know.
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
swissspidy
requested a review
from a team
swissspidy approved these changes Jun 4, 2020
Copy link
Contributor Author
vsamoletov
commented
Jun 4, 2020
vsamoletov commented
Jun 4, 2020@swissspidy could you please also review 68d96c9
vsamoletov
requested a review
from swissspidy
swissspidy
requested a review
from a team
swissspidy approved these changes Jun 4, 2020
swissspidy
requested a review
from schlessera
schlessera approved these changes Jun 4, 2020
schlessera
changed the title
Fixes: #5356
Throw exception when misusing error_to_string()
schlessera
added
the
bug
label
schlessera
added this to the
2.5.0 milestone
schlessera
merged commit
d7df11b
into
wp-cli:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment