Only suppress global parameters if set as true by austinginder · Pull Request #5455 · wp-cli/wp-cli

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@austinginder

Copy link

Contributor

@austinginder austinginder commented

Oct 16, 2020

edited by thrijith

Loading

Fixes #5453

@austinginder austinginder requested a review from a team as a code owner

October 16, 2020 02:25

@thrijith thrijith added this to the 2.5.0 milestone

Oct 18, 2020
Copy link

Member

@thrijith thrijith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR @austinginder !

austinginder reacted with hooray emoji

@thrijith thrijith merged commit 7d1e93d into wp-cli:master

Oct 27, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thrijith thrijith thrijith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

Global parameters are always suppressed

2 participants

@austinginder @thrijith