[PHP 8] Add properties argument to __set_state magic method by TimothyBJacobs · Pull Request #5469 · wp-cli/wp-cli
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1k
Merged
schlessera merged 1 commit intowp-cli:masterfrom
Nov 12, 2020Merged
[PHP 8] Add properties argument to __set_state magic method#5469
schlessera merged 1 commit intowp-cli:masterfrom
[PHP 8] Add properties argument to __set_state magic method#5469
schlessera merged 1 commit intowp-cli:masterfrom
Conversation
Copy link
Contributor
TimothyBJacobs
commented
Nov 11, 2020
TimothyBJacobs
commented
On PHP 8 a fatal error is issued if a magic method doesn't match the expected signature.
PHP Fatal error: Method Test_Magic_Methods::__set_state() must take exactly 1 argument
TimothyBJacobs
requested a review
from a team
as a code owner
schlessera approved these changes Nov 12, 2020
schlessera
added this to the
2.5.0 milestone
schlessera
merged commit
6af36bf
into
wp-cli:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment