Disable automatic retry by default on certificate validation error by schlessera · Pull Request #5523 · wp-cli/wp-cli

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@schlessera

Copy link

Member

@schlessera schlessera commented

May 6, 2021

edited

Loading

This PR disables the automatic retrying of Utils/http_request() that was skipping certificate validation.

The new default is to produce a hard error on certificate errors.

This PR also adds a new --insecure flag to the cli update command that turns this retrying back on when explicitly requested, which allows manually going back to the previous behavior.

Subsequent PRs on the command repositories will add a similar --insecure flag to the appropriate commands on the following repositories:

@schlessera schlessera force-pushed the fix/require-insecure-flag-for-http-retry branch from 25b6969 to 69a352b Compare

May 10, 2021 15:01

@schlessera schlessera merged commit 6f4e5dd into master

May 10, 2021

@schlessera schlessera deleted the fix/require-insecure-flag-for-http-retry branch

May 10, 2021 15:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

1 participant

@schlessera