Disable automatic retry by default on certificate validation error by schlessera · Pull Request #5523 · wp-cli/wp-cli
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1k
Merged
schlessera merged 9 commits intomasterfrom
May 10, 2021Merged
Disable automatic retry by default on certificate validation error#5523
schlessera merged 9 commits intomasterfrom
Disable automatic retry by default on certificate validation error#5523
schlessera merged 9 commits intomasterfrom
Conversation
Copy link
Member
This PR disables the automatic retrying of Utils/http_request() that was skipping certificate validation.
The new default is to produce a hard error on certificate errors.
This PR also adds a new --insecure flag to the cli update command that turns this retrying back on when explicitly requested, which allows manually going back to the previous behavior.
Subsequent PRs on the command repositories will add a similar --insecure flag to the appropriate commands on the following repositories:
-
wp-cli/config-command=> Add--insecureflag toconfig create&config shuffle-saltscommands config-command#128 -
wp-cli/core-command=> Add--insecureflag tocore download&core updatecommands core-command#186 -
wp-cli/extension-command=> Add--insecureflag toplugin|theme install&plugin\theme updatecommands extension-command#287 -
wp-cli/checksum-command=> Add--insecureflag tocore|plugin verify-checksumscommands checksum-command#86 -
wp-cli/package-command=> Add--insecureflag topackage installcommand package-command#138
schlessera
added this to the
2.5.0 milestone
schlessera
requested a review
from a team
as a code owner
This was referenced
May 7, 2021Merged
schlessera added 8 commits
May 10, 2021 16:00
schlessera
force-pushed
the
fix/require-insecure-flag-for-http-retry
branch
from
25b6969 to
69a352b
Compare
schlessera
merged commit
6f4e5dd
into
master
schlessera
deleted the
fix/require-insecure-flag-for-http-retry
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment