Handle optional option values in `SynopsisParser::render()` by ssnepenthe · Pull Request #5618 · wp-cli/wp-cli
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1k
Merged
schlessera merged 3 commits intowp-cli:masterfrom
ssnepenthe:optional-option-value
Jun 30, 2022Merged
Handle optional option values in SynopsisParser::render()#5618
schlessera merged 3 commits intowp-cli:masterfrom
ssnepenthe:optional-option-value
Handle optional option values in SynopsisParser::render()#5618
schlessera merged 3 commits intowp-cli:masterfrom
ssnepenthe:optional-option-value
Conversation
ssnepenthe
requested a review
from a team
as a code owner
wojsmol reviewed Feb 7, 2022
tests/test-synopsis.php
Outdated
Show resolved
Hide resolved
tests/test-synopsis.php Outdated Show resolved Hide resolved
ssnepenthe added 2 commits
February 7, 2022 21:57
Copy link
Contributor Author
ssnepenthe
commented
Jun 22, 2022
ssnepenthe commented
Jun 22, 2022@wojsmol is there anything else that needs to be addressed in order for the pr to be merged?
schlessera approved these changes Jun 30, 2022
schlessera
added this to the
2.7.0 milestone
schlessera
added
the
scope:framework
label
schlessera
merged commit
5508a6d
into
wp-cli:master
schlessera
changed the title
Handle optional option values in SynopsisParser::render()
Handle optional option values in SynopsisParser::render()
Copy link
drzraf
commented
Feb 21, 2023
drzraf commented
Feb 21, 2023I believe the combination with default doesn't work. (It'd gives true as a value instead of the one defined by default contrary to the string-based synopsis)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment