Add missing `$upgrade` argument to `enable_maintenance_mode` filter by dilipbheda · Pull Request #5630 · wp-cli/wp-cli

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@dilipbheda

Copy link

Contributor

@dilipbheda dilipbheda commented

Apr 8, 2022

edited

Loading

Fixed: #5629

As per the inline document, it should be required in the filter.

@dilipbheda dilipbheda requested a review from a team as a code owner

April 8, 2022 05:14
Copy link

Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the PR!

dilipbheda reacted with heart emoji

@danielbachhuber danielbachhuber added this to the 2.7.0 milestone

Jul 20, 2022

@danielbachhuber danielbachhuber changed the title Add missing filter argument Add missing $upgrade argument to enable_maintenance_mode filter

Jul 20, 2022

@danielbachhuber danielbachhuber merged commit 43eeee8 into wp-cli:master

Jul 20, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

Missing apply filters argument

2 participants

@dilipbheda @danielbachhuber