Fix return type of make_progress_bar by szepeviktor · Pull Request #5715 · wp-cli/wp-cli

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

danielbachhuber merged 1 commit intowp-cli:mainfrom

szepeviktor:patch-2

Jan 1, 2023

Merged

Fix return type of make_progress_bar#5715

danielbachhuber merged 1 commit intowp-cli:mainfrom

szepeviktor:patch-2

Conversation

@szepeviktor

Copy link

Contributor

Docblocks are absolute (FQCN).

@szepeviktor szepeviktor requested a review from a team as a code owner

December 28, 2022 22:18

@szepeviktor

Copy link

Contributor Author

The not-so-wise relative would be @return Bar|NoOp

@danielbachhuber danielbachhuber added this to the 2.8.0 milestone

Jan 1, 2023

@danielbachhuber danielbachhuber added the scope:documentation

Related to documentation

label

Jan 1, 2023
Copy link

Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@danielbachhuber danielbachhuber merged commit 6af4182 into wp-cli:main

Jan 1, 2023

@szepeviktor szepeviktor deleted the patch-2 branch

January 1, 2023 16:12

@szepeviktor

Copy link

Contributor Author

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees

No one assigned

Labels

scope:documentation

Related to documentation

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@szepeviktor @danielbachhuber