Update docker runner to resolve docker path using `/usr/bin/env` by thelovekesh · Pull Request #5936 · wp-cli/wp-cli
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1k
Merged
Update docker runner to resolve docker path using /usr/bin/env#5936
schlessera merged 2 commits intowp-cli:mainfrom
thelovekesh:patch-1
Update docker runner to resolve docker path using /usr/bin/env#5936
schlessera merged 2 commits intowp-cli:mainfrom
thelovekesh:patch-1
Conversation
Copy link
Member
thelovekesh
commented
Apr 26, 2024
thelovekesh
commented
Sometimes, the WP CLI process doesn't have access to PATH and it gives an error. This PR aims to resolve those binary using env which is already done for binaries like mysql.
Related: #5935
thelovekesh
requested a review
from a team
as a code owner
swissspidy reviewed Apr 26, 2024
php/WP_CLI/Runner.php
Outdated
Show resolved
Hide resolved
php/WP_CLI/Runner.php Outdated Show resolved Hide resolved
thelovekesh
requested a review
from swissspidy
swissspidy
added
the
scope:framework
label
swissspidy
added this to the
2.11.0 milestone
swissspidy approved these changes Apr 26, 2024
Copy link
Member Author
thelovekesh
commented
Apr 26, 2024
thelovekesh commented
Apr 26, 2024@swissspidy Should we change these occurrences with Utils\force_env_on_nix_systems()?
Line 1782 in 46051ea
| $result = Process::create( '/usr/bin/env which mysql', null, null )->run(); |
Copy link
Member
swissspidy
commented
Apr 26, 2024
swissspidy commented
Apr 26, 2024Probably? cc @schlessera for 2nd opinion
schlessera
merged commit
d1f69d8
into
wp-cli:main
thelovekesh
deleted the
patch-1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment