One notice for all missing db tables by shadyvb · Pull Request #506 · xwp/stream

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@shadyvb

Copy link Copy Markdown

Contributor

@shadyvb shadyvb commented

May 6, 2014

Before:
download

/cc @fjarrett

@shadyvb

Copy link Copy Markdown

Contributor Author

shadyvb commented

May 6, 2014

Worth noting that Stream should probably skip any queries if it found that its tables aren't there.

stream.php Outdated

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use _n here?

Copy link Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in aefb3a3

frankiejarrett added a commit that referenced this pull request

May 7, 2014

@frankiejarrett frankiejarrett merged commit e40732d into develop

May 7, 2014

@frankiejarrett frankiejarrett deleted the issue-no-tables-notice-fix branch

May 7, 2014 23:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shadyvb @lukecarbis @frankiejarrett