Bring back usage of cached labels by shadyvb · Pull Request #586 · xwp/stream

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@shadyvb

Copy link Copy Markdown

Contributor

@shadyvb shadyvb commented

Jun 29, 2014

Fixes #565 and replaces #566

@shadyvb

Copy link Copy Markdown

Contributor Author

shadyvb commented

Jun 29, 2014

@fjarrett This probably is the best way to go IMHO. Please review and test.

@frankiejarrett

Copy link Copy Markdown

Contributor

@shadyvb This PR reintroduces a bug with the EditFlow plugin similar to what was fixed in #498.

Notice: Undefined property: stdClass::$name in /srv/www/wordpress-trunk/wp-content/plugins/stream-old/connectors/taxonomies.php on line 118

@frankiejarrett

Copy link Copy Markdown

Contributor

@shadyvb I fixed the conflict with EditFlow.

frankiejarrett added a commit that referenced this pull request

Jul 18, 2014

@frankiejarrett frankiejarrett merged commit 56cdb32 into develop

Jul 18, 2014

@frankiejarrett frankiejarrett deleted the connector-based-labels-refresh branch

July 18, 2014 19:36

@frankiejarrett

Copy link Copy Markdown

Contributor

@shadyvb

Copy link Copy Markdown

Contributor Author

shadyvb commented

Jul 21, 2014

@fjarrett I'll pursue this tonight, any insights you might have discovered are welcome.

shadyvb added a commit that referenced this pull request

Jul 22, 2014

@shadyvb

Copy link Copy Markdown

Contributor Author

shadyvb commented

Jul 22, 2014

@fjarrett #597 does fix this issue, tested both plugins.

frankiejarrett added a commit that referenced this pull request

Jul 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Labels not seen for CPT registered on init with default priority

2 participants

@shadyvb @frankiejarrett