Pool table instances to make PureJavaSnappy thread safe by bokken · Pull Request #271 · xerial/snappy-java
Navigation Menu
{{ message }}
xerial / snappy-java Public
- Notifications You must be signed in to change notification settings
- Fork 252
Merged
xerial merged 1 commit intoxerial:masterfrom
Jan 20, 2021Merged
Pool table instances to make PureJavaSnappy thread safe#271
xerial merged 1 commit intoxerial:masterfrom
Pool table instances to make PureJavaSnappy thread safe#271
xerial merged 1 commit intoxerial:masterfrom
Conversation
xerial
self-assigned this
bokken commented Dec 15, 2020
| table); | ||
| compressed.position(compressed.position() + written); | ||
| return written; | ||
| final short[] table = getTable(); |
Copy link Copy Markdown
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not need to be obtained from within the synchronized blocks
Copy link Copy Markdown
Contributor Author
bokken
commented
Jan 20, 2021
bokken commented
Jan 20, 2021@xerial any idea when we can get this fix released?
I just ran into an issue where the pure java implementation was used unexpectedly (directory permission issues where lib was extracted) and it resulted in corrupt content (rather than the previous failure if lib could not be loaded).
xerial
merged commit
110727e
into
xerial:master
Copy link Copy Markdown
Owner
xerial
commented
Jan 20, 2021
xerial commented
Jan 20, 2021I'm now preparing 1.1.8.3, including the CRC32 improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants