Fix xaxis_*_iterator shape and strides types by Stef-Sijben · Pull Request #2747 · xtensor-stack/xtensor
added 3 commits
November 22, 2023 14:03Test not only `xarray` inputs, but also `xtensor` and `xtensor_fixed`. These are currently failing. Also test some more cases with `column_major` inputs.
An `xaxis_slice_iterator` always refers to a 1d view, so just use an array of size 1 for the shape and stride. Another type would probably be more optimal in case of compile-time fixed size (e.g. `xtensor_fixed`), but at least this is correct. Always use runtime dimensionality `xaxis_iterator` shape and strides. Other types would probably be more optimal in case of compile-time fixed dimension and/or size (e.g. `xtensor`, `xtensor_fixed`), but at least this is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters