Fix find_package by mircomarahrens · Pull Request #321 · xtensor-stack/xtensor-python
Navigation Menu
{{ message }}
xtensor-stack / xtensor-python Public
- Notifications You must be signed in to change notification settings
- Fork 67
Draft
mircomarahrens wants to merge 4 commits intoxtensor-stack:masterfrom
Draft
Fix find_package#321
mircomarahrens wants to merge 4 commits intoxtensor-stack:masterfrom
Fix find_package#321
mircomarahrens wants to merge 4 commits intoxtensor-stack:masterfrom
Conversation
Copy link Copy Markdown
mircomarahrens
commented
May 13, 2025
mircomarahrens
commented
- remove cmake\FindNumpy.cmake
- provide fix find_package(Python COMPONENTS Interpreter Development.Module NumPy REQUIRED) in CMakeLists.txt
mircomarahrens added 3 commits
February 1, 2025 18:40
mircomarahrens
marked this pull request as draft
mircomarahrens
force-pushed
the
master
branch
from
43197be to
43b71fe
Compare
LecrisUT reviewed Jul 31, 2025
| add_library(xtensor-python INTERFACE) | ||
| target_include_directories(xtensor-python INTERFACE | ||
| "$<BUILD_INTERFACE:${XTENSOR_PYTHON_INCLUDE_DIR};${pybind11_INCLUDE_DIRS};${NUMPY_INCLUDE_DIRS}>" | ||
| "$<BUILD_INTERFACE:${XTENSOR_PYTHON_INCLUDE_DIR};${pybind11_INCLUDE_DIRS};${Python_NumPy_INCLUDE_DIR}>" |
Copy link Copy Markdown
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to target_link_libraries, i.e.
target_link_libraries(xtensor-python INTERFACE "$<BUILD_INTERFACE:Python::NumPy>" )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants