refactor: drop node 10 by jly36963 · Pull Request #421 · yargs/yargs-parser

Conversation

@jly36963

Removed 10, added 16, updated tscc version because optimize didn't like type annotations on try/catch variables.

@jly36963 jly36963 marked this pull request as ready for review

October 22, 2021 01:25

bcoe

bcoe approved these changes Oct 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tahnks

const minNodeVersion = (process && process.env && process.env.YARGS_MIN_NODE_VERSION)
? Number(process.env.YARGS_MIN_NODE_VERSION)
: 10
: 12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this 👍 solid work.

2 participants

@jly36963 @bcoe