Serhiy Storchaka storchaka at gmail.com
Fri Jun 14 15:47:50 CEST 2013

• Previous message: [Python-Dev] cpython (2.7): Fix comment blocks. Adjust blocksize to a power-of-two for better divmod
• Next message: [Python-Dev] cpython (2.7): Fix comment blocks. Adjust blocksize to a power-of-two for better divmod
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

14.06.13 11:46, Antoine Pitrou написав(ла):
> On Fri, 14 Jun 2013 07:06:49 +0200 (CEST)
> raymond.hettinger <python-checkins at python.org> wrote:
>> http://hg.python.org/cpython/rev/5accb0ac8bfb
>> changeset:   84116:5accb0ac8bfb
>>    Fix comment blocks.  Adjust blocksize to a power-of-two for better divmod computations.
>
> Is there any rationale for changing the heuristic from "fits in a whole
> number of cachelines" to "allows fast division by the blocksize"?
>
> I personally would prefer if such changes were justified a bit more
> than by a one-liner changeset message without any corresponding open
> issue.

I share the doubts of Antoine and I was going to write the same comment. 
I thought there were good reasons for previous code. What has changed?

---

• Previous message: [Python-Dev] cpython (2.7): Fix comment blocks. Adjust blocksize to a power-of-two for better divmod
• Next message: [Python-Dev] cpython (2.7): Fix comment blocks. Adjust blocksize to a power-of-two for better divmod
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Python-Dev mailing list