Home Original page

[Python-Dev] cpython (2.7): Fix comment blocks. Adjust blocksize to a power-of-two for better divmod

Eli Bendersky eliben at gmail.com
Tue Jun 18 06:05:53 CEST 2013 
On Fri, Jun 14, 2013 at 6:47 AM, Serhiy Storchaka <storchaka at gmail.com>wrote:

> 14.06.13 11:46, Antoine Pitrou написав(ла):
>
>> On Fri, 14 Jun 2013 07:06:49 +0200 (CEST)
>> raymond.hettinger <python-checkins at python.org> wrote:
>>
>>> http://hg.python.org/cpython/**rev/5accb0ac8bfb<http://hg.python.org/cpython/rev/5accb0ac8bfb>
>>> changeset:   84116:5accb0ac8bfb
>>>    Fix comment blocks.  Adjust blocksize to a power-of-two for better
>>> divmod computations.
>>>
>>
>> Is there any rationale for changing the heuristic from "fits in a whole
>> number of cachelines" to "allows fast division by the blocksize"?
>>
>> I personally would prefer if such changes were justified a bit more
>> than by a one-liner changeset message without any corresponding open
>> issue.
>>
>
> I share the doubts of Antoine and I was going to write the same comment. I
> thought there were good reasons for previous code. What has changed?
>

I agree it would be interesting to hear about the reasons for the change.
Raymond?

Eli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-dev/attachments/20130617/f87c2c70/attachment.html>
More information about the Python-Dev mailing list