[OGUI-1847] Fix arrays saved as objects and other small fixes by Deaponn · Pull Request #3236 · AliceO2Group/WebUi
Navigation Menu
{{ message }}
AliceO2Group / WebUi Public
- Notifications You must be signed in to change notification settings
- Fork 14
Conversation
Copy link Copy Markdown
Collaborator
Deaponn
commented
Dec 15, 2025
Deaponn
commented
This PR fixes a couple of bugs:
- one where arrays are converted into objects on configuration save (
[true, 'text', 99]becomes{ 0: true, 1: 'text', 2: 99 }) - one where edit difference highlighting fails for FormToggleInput component
- one where empty objects and lists are not parsed correctly which causes them to be lost while saving
I have JIRA issue created
- branch and/or PR name(s) includes JIRA ID
- issue "Status" is set to "In review"
- PR labels are selected
Deaponn added 2 commits
December 15, 2025 08:59fix: properly highlighting modified toggle buttons
Deaponn
requested a review
from graduta
as a code owner
Deaponn
added
the
Configuration GUI
label
Deaponn
requested review from
piechnikk and
sKrzysieK
piechnikk approved these changes Dec 16, 2025
Copy link Copy Markdown
Collaborator
piechnikk
left a comment
piechnikk
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
sKrzysieK approved these changes Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment