Fix ADBC driver path resolution when `importlib.util` was not implicitly loaded by henryharbeck · Pull Request #135 · duckdb/duckdb-python
Navigation Menu
{{ message }}
duckdb / duckdb-python Public
- Notifications You must be signed in to change notification settings
- Fork 76
Merged
evertlammerts merged 1 commit intoduckdb:v1.4-andiumfrom
Oct 28, 2025Merged
Conversation
Copy link Copy Markdown
henryharbeck
commented
Oct 20, 2025
henryharbeck
commented
Fixes #134
Also removes a print statement when the driver is found.
evertlammerts
changed the base branch from
main
to
v1.4-andium
evertlammerts
changed the base branch from
v1.4-andium
to
main
Copy link Copy Markdown
Collaborator
evertlammerts
commented
Oct 27, 2025
evertlammerts commented
Oct 27, 2025Thanks @henryharbeck, looks good to me. Can you rebase this onto the v1.4-andium branch? That way it can make it into 1.4.2.
henryharbeck
changed the base branch from
main
to
v1.4-andium
henryharbeck
changed the base branch from
v1.4-andium
to
main
henryharbeck
changed the base branch from
main
to
v1.4-andium
henryharbeck
force-pushed
the
main
branch
from
66abd7e to
98efbea
Compare
henryharbeck
closed this
henryharbeck
force-pushed
the
main
branch
from
98efbea to
2cbb98d
Compare
henryharbeck
reopened this
Copy link Copy Markdown
Author
henryharbeck
commented
Oct 28, 2025
henryharbeck commented
Oct 28, 2025Thanks, done
evertlammerts
enabled auto-merge
evertlammerts approved these changes Oct 28, 2025
Copy link Copy Markdown
Collaborator
evertlammerts
left a comment
evertlammerts
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
evertlammerts
added this pull request to the merge queue
henryharbeck
mentioned this pull request
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants