Add explicit .pl(lazy=True) overload by J-Meyers · Pull Request #172 · duckdb/duckdb-python
Navigation Menu
{{ message }}
duckdb / duckdb-python Public
- Notifications You must be signed in to change notification settings
- Fork 76
Merged
evertlammerts merged 1 commit intoduckdb:v1.4-andiumfrom
Nov 10, 2025Merged
Add explicit .pl(lazy=True) overload#172
evertlammerts merged 1 commit intoduckdb:v1.4-andiumfrom
Add explicit .pl(lazy=True) overload#172
evertlammerts merged 1 commit intoduckdb:v1.4-andiumfrom
Conversation
Copy link Copy Markdown
Contributor
J-Meyers
commented
Nov 9, 2025
J-Meyers
commented
Followed: python/mypy#8634
Prior to this mypy would complain when using .pl(lazy=True).collect() this will prevent that
J-Meyers
force-pushed
the
pl_lazy_typing
branch
from
c87c7cc to
10e0ef3
Compare
Copy link Copy Markdown
Collaborator
evertlammerts
commented
Nov 10, 2025
evertlammerts commented
Nov 10, 2025Hey @J-Meyers , thanks for the PR. I think the third (Union) overload is not necessary?
Copy link Copy Markdown
Contributor Author
I think it still is necessary if for some reason the value of lazy is determined at runtime instead of being a simple literal. One case if this could be of you had some wrapper function around the calls to duckdb that took lazy as an argument, then that could return either lazy frames or regular.
…________________________________ From: Evert Lammerts ***@***.***> Sent: Monday, November 10, 2025 4:09:09 AM To: duckdb/duckdb-python ***@***.***> Cc: Julian Meyers ***@***.***>; Mention ***@***.***> Subject: Re: [duckdb/duckdb-python] Add explicit .pl(lazy=True) overload (PR #172) [https://avatars.githubusercontent.com/u/2683350?s=20&v=4]evertlammerts left a comment (duckdb/duckdb-python#172)<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_duckdb_duckdb-2Dpython_pull_172-23issuecomment-2D3510607924&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=MdlGNggs4ba2ijajU3oxJJgnT7XUUcVtAcqALzH8Cc4&m=z7ONwbMan0UnXCBdhxWWdlc5X5zfUoiJ46gCykRlbv-J07Y5j6xrH74DE1-aXsCm&s=1Yc9bQBX6rtfc7J3_sVaKEgW_9SrH3Xe2ZWjpLzpShQ&e=> Hey @J-Meyers<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_J-2DMeyers&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=MdlGNggs4ba2ijajU3oxJJgnT7XUUcVtAcqALzH8Cc4&m=z7ONwbMan0UnXCBdhxWWdlc5X5zfUoiJ46gCykRlbv-J07Y5j6xrH74DE1-aXsCm&s=Qh1rh7REFMFudNkVCuZzCS8q1aVmd89KVI7IlIuvs60&e=> , thanks for the PR. I think the third (Union) overload is not necessary? — Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_duckdb_duckdb-2Dpython_pull_172-23issuecomment-2D3510607924&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=MdlGNggs4ba2ijajU3oxJJgnT7XUUcVtAcqALzH8Cc4&m=z7ONwbMan0UnXCBdhxWWdlc5X5zfUoiJ46gCykRlbv-J07Y5j6xrH74DE1-aXsCm&s=1Yc9bQBX6rtfc7J3_sVaKEgW_9SrH3Xe2ZWjpLzpShQ&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM453PKN6V6RR7DMFOCUXVD34BP3ZAVCNFSM6AAAAACLRUCDNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKMJQGYYDOOJSGQ&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=MdlGNggs4ba2ijajU3oxJJgnT7XUUcVtAcqALzH8Cc4&m=z7ONwbMan0UnXCBdhxWWdlc5X5zfUoiJ46gCykRlbv-J07Y5j6xrH74DE1-aXsCm&s=qA6Jfc-oDmaZFW5tHoRvtH62wmNEZAcgEJl83t5u9WI&e=>. You are receiving this because you were mentioned.
evertlammerts approved these changes Nov 10, 2025
Copy link Copy Markdown
Collaborator
evertlammerts
left a comment
evertlammerts
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
J-Meyers
deleted the
pl_lazy_typing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment