Corrected types for CreateRequest by clintonb · Pull Request #2930 · firebase/firebase-admin-node
Navigation Menu
{{ message }}
firebase / firebase-admin-node Public
- Notifications You must be signed in to change notification settings
- Fork 415
Open
clintonb wants to merge 1 commit intofirebase:mainfrom
Open
Corrected types for CreateRequest#2930
clintonb wants to merge 1 commit intofirebase:mainfrom
Corrected types for CreateRequest#2930
clintonb wants to merge 1 commit intofirebase:mainfrom
Conversation
Copy link Copy Markdown
clintonb
commented
May 27, 2025
clintonb
commented
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
Testing
- Make sure all existing tests in the repository pass after your change.
- If you fixed a bug or added a feature, add a new test to cover your code.
API Changes
- At this time we cannot accept changes that affect the public API. If you'd like to help
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.
Per firebase#1508, `phoneNumber` is not nullable for create requests.
Copy link Copy Markdown
Author
clintonb
commented
Aug 8, 2025
clintonb commented
Aug 8, 2025Can I get eyes on this, please? The docs don't mention who to contact after opening a ticket/pull request.
lahirumaramba
self-assigned this
lahirumaramba
self-requested a review
lahirumaramba
added
the
api: auth
label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment