Added return type for `bucket` function by sarmadgulzar · Pull Request #591

Added return type for `bucket` function by sarmadgulzar · Pull Request #591 · firebase/firebase-admin-python

Merged

Nov 30, 2021

Merged

Added return type for `bucket` function#591
lahirumaramba merged 1 commit intofirebase:masterfrom
sarmadgulzar:add-a-missing-return-type

Copy link Copy Markdown

Contributor

Added google.cloud.storage.Bucket return type for storage.bucket function for better typing support

lahirumaramba self-requested a review

lahirumaramba self-assigned this

Copy link Copy Markdown

Contributor Author

@lahirumaramba how can I rerun the CLA workflow? I wasn't aware of this so I only signed up after the check failed!

Copy link Copy Markdown

Member

@lahirumaramba how can I rerun the CLA workflow? I wasn't aware of this so I only signed up after the check failed!

Thank you! I triggered the CLA check.

lahirumaramba approved these changes Nov 30, 2021

Copy link Copy Markdown

Member

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sarmadgulzar for the contribution! LGTM!

lahirumaramba merged commit 348a90d into firebase:master

sarmadgulzar deleted the add-a-missing-return-type branch

None yet