chore: Update Node.js version in CI workflow by lahirumaramba · Pull Request #602 · firebase/firebase-admin-python
Navigation Menu
{{ message }}
firebase / firebase-admin-python Public
- Notifications You must be signed in to change notification settings
- Fork 352
Merged
chore: Update Node.js version in CI workflow#602
lahirumaramba merged 2 commits intomasterfrom
chore: Update Node.js version in CI workflow#602
lahirumaramba merged 2 commits intomasterfrom
Conversation
Copy link Copy Markdown
Member
- Firebase CLI dropped support for Node.js 10. Updating the Node.js version to
1216 for emulator test setup.
- Firebase CLI dropped support for Node.js 10. Updating the Node.js version to 12 for emulator test setup.
lahirumaramba
requested a review
from hiranya911
lahirumaramba
assigned
hiranya911
hiranya911 approved these changes Jan 7, 2022
Copy link Copy Markdown
Contributor
hiranya911
left a comment
hiranya911
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Should we go all the way to Node 16 for this?
hiranya911
assigned
lahirumaramba and unassigned
hiranya911
Copy link Copy Markdown
Member Author
lahirumaramba
commented
Jan 7, 2022
lahirumaramba commented
Jan 7, 2022Thanks.
Should we go all the way to Node 16 for this?
Good call. Yes, let's do 16!
Update the version to current LTS 16
lahirumaramba
merged commit
6ee8528
into
master
lahirumaramba
deleted the
lm-update-nodev
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants