Update `github.ref` value in `release.yml` by lahirumaramba · Pull Request #730 · firebase/firebase-admin-python
Navigation Menu
{{ message }}
firebase / firebase-admin-python Public
- Notifications You must be signed in to change notification settings
- Fork 352
Merged
Update github.ref value in release.yml#730
lahirumaramba merged 1 commit intomasterfrom
Update github.ref value in release.yml#730
lahirumaramba merged 1 commit intomasterfrom
Conversation
Copy link Copy Markdown
Member
lahirumaramba
commented
Oct 12, 2023
lahirumaramba
commented
- Fixes the release workflow to match the updates to
github.ref github.refnow returns a fully-formed valuerefs/heads/...- See https://github.blog/changelog/2023-09-13-github-actions-updates-to-github_ref-and-github-ref/
- Fixes the release workflow to match the updates to `github.ref` - `github.ref` now returns a fully-formed value `refs/heads/...` - See https://github.blog/changelog/2023-09-13-github-actions-updates-to-github_ref-and-github-ref/
lahirumaramba
requested a review
from jonathanedey
lahirumaramba
assigned
jonathanedey
jonathanedey approved these changes Oct 12, 2023
Copy link Copy Markdown
Collaborator
jonathanedey
left a comment
jonathanedey
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lahirumaramba
merged commit
4052a3c
into
master
lahirumaramba
deleted the
lm-fix-releasewf
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants